chore: upgrade rusty_v8 to 0.48.1 #15310
Conversation
bartlomieju
force-pushed
the
upgrade_rusty_v8
branch
from
c76d0e1
to
fcf111f
Compare
bartlomieju
changed the title
core/bindings.rs
Outdated
| ) { | ||
| // SAFETY: This pointer is definitely valid for the lifetime of this function. | ||
| let isolate = unsafe { &mut *isolate }; | ||
| isolate.set_microtasks_policy(v8::MicrotasksPolicy::Explicit); |
There was a problem hiding this comment.
This callback is called whenever a wasm streaming resource is closed or aborted, which happens from Deno-internal JS code (the handleWasmStreaming function in 26_fetch.js). Therefore, even if we skip the microtask checkpoint when resolving resolver, the microtasks will run when the JS stack is emptied, which is just after this callback runs. As such, setting the microtasks policy doesn't actually do anything – it's setting the callback that seems to make the difference.
There was a problem hiding this comment.
Thanks, I removed that. I will check later why the callback needs to be set.
|
Nice work @bartlomieju - I saw an earlier version of this PR and glad to see the callback not setting and unsetting modes. |
No description provided.