Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdir should not be recursive by default #1530

Merged
merged 1 commit into from
Jan 18, 2019
Merged

mkdir should not be recursive by default #1530

merged 1 commit into from
Jan 18, 2019

Conversation

ry
Copy link
Member

@ry ry commented Jan 15, 2019 •
edited
Loading

cc @cody

@ry ry requested a review from piscisaureus January 15, 2019 15:16
@ry ry mentioned this pull request Jan 15, 2019
Closed
@MarkTiedemann MarkTiedemann mentioned this pull request Jan 16, 2019
Closed
@ry
mkdir should not be recursive by default
6138ad0 
It should return an error if a file with the given path exists and
recursive isn't specified.

Because mode is not used on windows and rarely used in unix, it is made
to the last parameter.

In collaboration with Stefan Dombrowski <[email protected]>
piscisaureus
piscisaureus approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Am I getting senile? I would swear I had approved this already.

@ry ry merged commit 315e4ab into denoland:master Jan 18, 2019
@ry
Copy link
Member Author

ry commented Jan 18, 2019

Maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus