fix(task): subcommand parser skips global args #15297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15290
I decided to slice
args
inflags_from_vec()
, rather than intask_parse()
, to avoid passingtask_parse()
more data than is necessary. This makes it easier to see thattask_parse()
doesn't care about the "--quiet" indeno --quiet task echo
.Not happy with the way I'm slicing the subcommand's args from
args
. I couldn't find anything in clap to get the index of the subcommand name, or a function likeindex_of()
for subcommands. Suggestions are welcome.