Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add types for Deno.core.print() #15283

Merged
merged 3 commits into from
Jul 31, 2022

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented Jul 22, 2022

Resolves #15282.

Unfortunately I was unable to run the format script because dprint doesn't work behind my HTTP proxy.

Also, I'm getting an error when I try to run the lint script. It could be related:

dlint
error: Uncaught (in promise) Error: gitLsFiles failed
    throw new Error("gitLsFiles failed");
          ^
    at getFilesFromGit (file:https:///home/zicklag/git/other/deno/tools/util.js:23:11)
    at async getSources (file:https:///home/zicklag/git/other/deno/tools/util.js:87:12)
    at async dlint (file:https:///home/zicklag/git/other/deno/tools/lint.js:16:23)
    at async main (file:https:///home/zicklag/git/other/deno/tools/lint.js:149:5)
    at async file:https:///home/zicklag/git/other/deno/tools/lint.js:155:1

This is a super small change, that should pass both, I think.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2022

CLA assistant check
All committers have signed the CLA.

@zicklag zicklag force-pushed the deno-core-print-ts branch 2 times, most recently from 2994de5 to fe43490 Compare July 22, 2022 21:00
@bartlomieju
Copy link
Member

Please format the code using tools/format.js

@zicklag
Copy link
Contributor Author

zicklag commented Jul 30, 2022

Once I get the chance, I'll try to find a workaround, but unfortunately dprint doesn't work for me behind my corporate proxy with a custom certificate:

Error resolving plugin https://plugins.dprint.dev/typescript-0.70.0.wasm: Error downloading https://plugins.dprint.dev/typescript-0.70.0.wasm - Error: https://plugins.dprint.dev/typescript-0.70.0.wasm: Connection Failed: tls connection init failed: invalid peer certificate contents: invalid peer certificate: UnknownIssuer
error: Uncaught (in promise) Error: dprint failed
    throw new Error("dprint failed");
          ^
    at dprint (file:https:///home/zicklag/git/other/deno/tools/format.js:14:11)
    at async main (file:https:///home/zicklag/git/other/deno/tools/format.js:20:3)
    at async file:https:///home/zicklag/git/other/deno/tools/format.js:41:1

I might be able to download the plugin through my browser and re-configure dprint to use a local file, but I've got to figure out how to do that.

@bartlomieju
Copy link
Member

@zicklag that's okay, I formatted the code for you.

@bartlomieju bartlomieju changed the title feat(typedefs): Add TypeScript Declaration for Deno.core.print() core: Add types for Deno.core.print() Jul 31, 2022
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju bartlomieju merged commit d81c5b5 into denoland:main Jul 31, 2022
@zicklag zicklag deleted the deno-core-print-ts branch July 31, 2022 20:54
crowlKats pushed a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno.core.print() Is Not Present in lib.deno_core.d.ts
3 participants