Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim_left_matches (deprecated) => trim_start_matches #1524

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

kevinkassimo
Copy link
Contributor

@kevinkassimo kevinkassimo commented Jan 15, 2019

For this on Rust 1.33 (trim_start_matches is added on Rust 1.30 so I would assume this patch would build):

error: use of deprecated item 'core::str::<impl str>::trim_left_matches': superseded by `trim_start_matches`
  --> ../../src/resolve_addr.rs:88:15
   |
88 |     let p = p.trim_left_matches(':');
   |               ^^^^^^^^^^^^^^^^^
   |
   = note: `-D deprecated` implied by `-D warnings`

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit f9c7c92 into denoland:master Jan 15, 2019
@kevinkassimo kevinkassimo deleted the patch-1 branch December 27, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants