Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): provide import map remapping diags and fixes #15165

Merged
merged 6 commits into from
Jul 14, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jul 12, 2022

This should be good for a test spin, but it needs tests.

@kitsonk kitsonk force-pushed the feat_import_map_diagnostics branch 2 times, most recently from 42736e5 to b7ab521 Compare July 13, 2022 05:58
@kitsonk kitsonk changed the title [WIP] feat(lsp): provide import map remapping diags and fixes feat(lsp): provide import map remapping diags and fixes Jul 13, 2022
@kitsonk kitsonk marked this pull request as ready for review July 13, 2022 05:58
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk force-pushed the feat_import_map_diagnostics branch from b7ab521 to 3fea602 Compare July 13, 2022 23:46
@kitsonk kitsonk merged commit 7e06d33 into denoland:main Jul 14, 2022
@kitsonk kitsonk deleted the feat_import_map_diagnostics branch July 14, 2022 01:12
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants