Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rid to Conn interface #1513

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Added rid to Conn interface #1513

merged 2 commits into from
Jan 14, 2019

Conversation

fancyplants
Copy link
Contributor

Adds the rid property to Conn to allow access to the resource ID of the incoming connection.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry reviewed Jan 13, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, sorry, I said I would do this : ) Thanks

Can you add a test? Just something like assert(conn.rid > 0); to exercise the member

ry
ry approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@ry ry merged commit fda604f into denoland:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fancyplants @CLAassistant @ry