Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permission_prompt_test #1509

Merged
merged 2 commits into from
Jan 13, 2019
Merged

Fix permission_prompt_test #1509

merged 2 commits into from
Jan 13, 2019

Conversation

ry
Copy link
Member

@ry ry commented Jan 13, 2019 •
edited

No description provided.

@ry ry requested a review from piscisaureus January 13, 2019 16:21
@ry
Fix permission_prompt_test
8d5c3de 
This problem was introduced in 37e3db (denoland#1504).
piscisaureus
piscisaureus approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if it fixes the issue.

@ry ry merged commit 8ae178e into denoland:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus