feat: add "unhandledrejection" event support (#12994) #15080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for "unhandledrejection" event.
This event will trigger event listeners registered using:
"globalThis.addEventListener("unhandledrejection")
"globalThis.onunhandledrejection"
This is done by registering a default handler using
"Deno.core.setPromiseRejectCallback" that allows to
handle rejected promises in JavaScript instead of Rust.
This commit will make it possible to polyfill
"process.on("unhandledRejection")" in the Node compat
layer.
Co-authored-by: Colin Ihrig <[email protected]>
bartlomieju
commented
Jul 5, 2022
cjihrig
approved these changes
Jul 14, 2022
| @@ -268,6 +268,10 @@ | |||
| terminate: opSync.bind(null, "op_terminate"), | |||
| opNames: opSync.bind(null, "op_op_names"), | |||
| eventLoopHasMoreWork: opSync.bind(null, "op_event_loop_has_more_work"), | |||
| setPromiseRejectCallback: opSync.bind( | |||
| null, | |||
| "op_set_promise_reject_callback", | |||
There was a problem hiding this comment.
Just a note - we'll need to provide an op_set_promise_reject_callback handler that rethrows the exception if we want to leverage op_set_uncaught_exception_callback to implement uncaughtException compat.
There was a problem hiding this comment.
Good point, I'll export default handler in an "internal" namespace so we can still call it
There was a problem hiding this comment.
Discussed offline, we're gonna land it as is and circle back if this is not enough to polyfill std/node
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Jul 14, 2022
…denoland#15080)" This reverts commit 1a7259b.
bartlomieju
added a commit
that referenced
this pull request
Jul 14, 2022
bartlomieju
added a commit
to bartlomieju/deno
that referenced
this pull request
Jul 15, 2022
…d#12994) (denoland#15080)" (denoland#15210)" This reverts commit f9b692e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-landing #12994, which was reverted in #15075 due
to flaky tests.