Web API: CustomEvent #1505
Web API: CustomEvent #1505
Conversation
| isTrusted: value, | ||
| target: this.target, | ||
| timeStamp: this.timeStamp | ||
| }); |
There was a problem hiding this comment.
the addition of these flags and the setter is in preparation for my EventTarget implementation, which will also rely on CustomEvent.
js/custom_event.ts
Outdated
|
|
||
| export class CustomEventInit extends event.EventInit | ||
| implements domTypes.CustomEventInit { | ||
| detail = null; |
There was a problem hiding this comment.
Probably detail: any | null = null?
Travis is complaining that you cannot assign non-null values to detail of type null
There was a problem hiding this comment.
👍 but any | null would be just any.
There was a problem hiding this comment.
Also, you are double initialising this... I would simply do:
detail: any;
Here and you have a default argument in the constructor which is then assigning to detail on construction. Also, I am not sure, but is detail readonly?
| bubbles = false, | ||
| cancelable = false, | ||
| composed = false, | ||
| detail = null |
There was a problem hiding this comment.
Actually, the problem is coming here. The constructor signature looks like this because it is inferring the default arguments:
constructor(bubbles?: boolean, cancelable?: boolean, composed?: boolean, detail?: null)This isn't what you want. You should be explicit about the type of detail at least.
js/custom_event.ts
Outdated
| } | ||
|
|
||
| // tslint:disable-next-line:no-any | ||
| get detail(): any | null { |
js/custom_event.ts
Outdated
| bubbles?: boolean, | ||
| cancelable?: boolean, | ||
| // tslint:disable-next-line:no-any | ||
| detail?: any | null |
js/custom_event.ts
Outdated
| customEventInitDict: domTypes.CustomEventInit = {} | ||
| ) { | ||
| super(type, customEventInitDict); | ||
| customEventAttributes.set(this, { |
There was a problem hiding this comment.
If you wanted to deal with this even better you could do:
const { detail = null } = customEventInitDict;
customEventAttributes.set(this, { detail });That is destructuring assignment with a default value.
This PR builds off of my previous one to extend
Eventwith the CustomEvent Web API spec.