Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(serde_v8): smallvec ByteString #15008

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jun 29, 2022

This commit changes Bytestring to use smallvec
internally. This avoids heap allows when deserializing
strings < 16 chars.

Revives #14204

Co-Authored-by: @AaronO

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit ebc8a3c into denoland:main Jun 30, 2022
dsherret pushed a commit to dsherret/deno that referenced this pull request Jun 30, 2022
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants