Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(unstable): Improve Deno.spawn() stdio API #14919

Merged
merged 15 commits into from
Jul 18, 2022
Merged

BREAKING(unstable): Improve Deno.spawn() stdio API #14919

merged 15 commits into from
Jul 18, 2022

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jun 20, 2022 •
edited
Loading

Blocked on #15098.
Blocked on test_util/std update.

Closes #14918.

@nayeemrmn
Copy link
Collaborator Author

Not sure how we can make changes to unstable APIs with these dependency loop-the-loops between cli and std workflows...

@bartlomieju
Copy link
Member

Not sure how we can make changes to unstable APIs with these dependency loop-the-loops between cli and std workflows...

What's the problem that you're facing?

@nayeemrmn
Copy link
Collaborator Author

We're running benchmarks on test_util/std/examples/chat/server_test.ts which uses the current spawn API. I think we could temporarily revert that to Deno.run() and bump the submodule, I need to check if that's the only one.

@nayeemrmn nayeemrmn marked this pull request as draft June 21, 2022 12:18
@nayeemrmn nayeemrmn mentioned this pull request Jun 21, 2022
Merged
@nayeemrmn nayeemrmn mentioned this pull request Jun 22, 2022
Merged
@nayeemrmn nayeemrmn marked this pull request as ready for review June 23, 2022 13:40
kt3k
kt3k approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this design. LGTM

cc @crowlKats What do you think?

bartlomieju
bartlomieju requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this as "Request changes" because I'd like to discuss it during CLI design meeting before landing. There are some use cases (like "unrefing" of child processes that need to be taken into account with such changes).

CC @cjihrig can you take a look as well?

bartlomieju
bartlomieju reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrade test_util/std/ submodule? Could it also be done in a separate PR?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bartlomieju bartlomieju added this to the 1.24 milestone Jul 13, 2022
bartlomieju
bartlomieju approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @nayeemrmn

@bartlomieju bartlomieju merged commit 45c4903 into denoland:main Jul 18, 2022
@nayeemrmn nayeemrmn deleted the spawn-stdio branch July 18, 2022 17:00
@lukas-runge lukas-runge mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

Proposed changes to Deno.spawn() API
3 participants
@nayeemrmn @bartlomieju @kt3k