feat(ops): support Result<impl Future<Output = Result<T, AnyError>> + 'static, AnyError>
#14869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
Result<impl Future<Output = Result<T, AnyError>> + 'static, AnyError>
nayeemrmn
reviewed
Jun 16, 2022
| @@ -398,6 +427,8 @@ fn is_handle_scope(arg: &syn::FnArg) -> bool { | |||
| || tokens(arg).ends_with(": & mut v8 :: HandleScope < 'a >") | |||
| || tokens(arg).ends_with(": & mut deno_core :: v8 :: HandleScope") | |||
| || tokens(arg).ends_with(": & mut deno_core :: v8 :: HandleScope < 'a >") | |||
| || tokens(arg).contains("mut v8 :: HandleScope") | |||
| || tokens(arg).ends_with(": & mut v8 :: HandeScope < 'scope >") | |||
There was a problem hiding this comment.
This case and the first two are covered by the .contains("mut v8 :: HandleScope") above, but I don't know if that should be there.
Should we just use regex in this function for the lifetime parameter?
AaronO
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support returning a
Result<impl Future<Output = Result<T, AnyError>> + 'static, AnyError>. An hybrid op where both sync and async phases are fallible.