Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): SourceMapGetter doesn't need Send + Sync #14808

Merged
merged 1 commit into from
Jun 7, 2022
Merged

refactor(core): SourceMapGetter doesn't need Send + Sync #14808

merged 1 commit into from
Jun 7, 2022

Conversation

bartlomieju
Copy link
Member

Removes unnecessary trait bounds for SourceMapGetter trait.

@bartlomieju bartlomieju requested a review from dsherret June 7, 2022 09:47
dsherret
dsherret approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 99f525a into denoland:main Jun 7, 2022
@bartlomieju bartlomieju deleted the source_map_getter_traits branch June 7, 2022 16:08
cjihrig pushed a commit that referenced this pull request Jun 9, 2022
@bartlomieju @cjihrig
refactor(core): SourceMapGetter doesn't need Send + Sync (#14808)
00904a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartlomieju @dsherret