fix(lsp): handle get diagnostic errors better #14776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles errors in
getDiagnostics
request where there are transient errors in getting the diagnostics which cause an output of:In the debug console, which is distracting to users and doesn't impact the usage of the extension. Also, when one specifier causes an issue, all requested specifiers get dropped, which isn't ideal. This will handle the whole failure of getting diagnostics better.