Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): do panic for import decl with empty named imports and default import #14773

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix(fmt): do panic for import decl with empty named imports and default import #14773

merged 2 commits into from
Jun 1, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 1, 2022 •
edited
Loading

bartlomieju
bartlomieju approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to wait for WPT fix before landing

@dsherret dsherret merged commit c01fcef into denoland:main Jun 1, 2022
@dsherret dsherret deleted the fix_fmt_named_imports branch June 1, 2022 23:36
bartlomieju pushed a commit that referenced this pull request Jun 2, 2022
@dsherret @bartlomieju
fix(fmt): do panic for import decl with empty named imports and defau…
cdb1f41 
…lt import (#14773)
bartlomieju pushed a commit that referenced this pull request Jun 2, 2022
@dsherret @bartlomieju
fix(fmt): do panic for import decl with empty named imports and defau…
22ef863 
…lt import (#14773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno panicked on fmt a empty import after a default import
2 participants
@dsherret @bartlomieju