chore: fix flaky integration::bench::multifile_summary test
#14771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
pushed a commit
that referenced
this pull request
Jun 2, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14732. The test is flaky because sometimes "parse url 6x" runs faster than "parse url 2x". I think it may be because the execution time difference between the two benches is quite small and if a CI runner has a small performance dip, it results in the parse url 2x being slower than the parse url 6x on occasion.
This PR changes the 6x to 200x creating a bigger difference. An alternative could also be to change the slower/faster to wildcards instead.