Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(serde_v8): add serde_v8::Global #14761

Merged
merged 5 commits into from
Jun 19, 2022
Merged

feat(serde_v8): add serde_v8::Global #14761

merged 5 commits into from
Jun 19, 2022

Conversation

littledivy
Copy link
Member

No description provided.

@littledivy littledivy marked this pull request as ready for review May 31, 2022 14:17
@littledivy littledivy requested a review from AaronO as a code owner May 31, 2022 14:17
bartlomieju
bartlomieju approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore for snapshots, but it's useful in general. LGTM

serde_v8/magic/global.rs Outdated Show resolved Hide resolved
@littledivy littledivy merged commit caaece0 into denoland:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@AaronO AaronO Awaiting requested review from AaronO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littledivy @bartlomieju