Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/web): EventSource #14730

Merged
merged 22 commits into from
Oct 31, 2023
Merged

feat(ext/web): EventSource #14730

merged 22 commits into from
Oct 31, 2023

Conversation

crowlKats
Copy link
Member

Closes #10298

@stale
Copy link

stale bot commented Jul 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2022
@crowlKats crowlKats removed the stale label Jul 30, 2022
@stale
Copy link

stale bot commented Sep 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 30, 2022
@crowlKats crowlKats removed the stale label Oct 1, 2022
# Conflicts:
#	runtime/js/99_main.js
#	tools/wpt/expectation.json
@crowlKats crowlKats marked this pull request as ready for review January 13, 2023 04:35
@titomitto
Copy link

titomitto commented Jan 21, 2023

@crowlKats When will this be merged? I've been waiting for EventSource for almost a year now

@crowlKats
Copy link
Member Author

@titomitto there are a bunch of tests that are not passing, but this is currently not a priority for me to work on

@titomitto
Copy link

At this point, deno is the only one that doesn't support it
Screenshot 2023-01-23 at 1 42 14 AM

@hazelnutcloud
Copy link

would love to have this feature since pocketbase uses SSE's for realtime database updates

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires rebase and presumably work to get the WPT tests for EventSource working.

@denizdogan
Copy link

@aapoalas Are you working on this PR? Would love to see this in Deno.

@comunidadio
Copy link

This would be so useful API to have out-of-the-box, like in the browser.

# Conflicts:
#	ext/fetch/26_fetch.js
#	ext/fetch/27_eventsource.js
#	ext/fetch/lib.rs
#	runtime/js/98_global_scope.js
@mcgear
Copy link

mcgear commented Sep 10, 2023

Where are we at with this one, anyway i can jump in and help with this? In need of this i think.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 3971618 into denoland:main Oct 31, 2023
13 checks passed
@crowlKats crowlKats deleted the eventsource branch October 31, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a EventSource implementation
8 participants