Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): op metrics op_names mismatch #14716

Merged
merged 3 commits into from
May 24, 2022
Merged

fix(core): op metrics op_names mismatch #14716

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18e2e9e
failing test
AaronO May 24, 2022
eb0766e
fix: use Deno.core.opNames()
AaronO May 24, 2022
0578e9d
fix test with .sort()
AaronO May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test with .sort()
  • Loading branch information
@AaronO
AaronO committed May 24, 2022
commit 0578e9d23f8681ea0683dff95ec6b76355d7cdd1
2 changes: 1 addition & 1 deletion cli/tests/unit/metrics_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Deno.test(function metricsForOpCrates() {
Deno.test(function opNamesMatch() {
assertEquals(
// @ts-ignore: Deno.core allowed
Deno.core.opNames(),
Deno.core.opNames().sort(),
// @ts-ignore: Deno.core allowed
Object.keys(Deno.core.ops).sort(),
);
Expand Down