fix: use int instead of double for timeout type.

[bokuweb]

Hi :) I found FIXME comment in ops.rs. I think it is better to use int instead of double for timeout type in flatbuffer. Because delay is rounded by typescript side like following. If not, please reject this PR.

https://github.com/denoland/deno/blob/master/js/timers.ts#L180-L184

[piscisaureus]

For a relative time-out value int is probably sufficient (it means the max time-out value is about 24 days). Are you sure it's definitely not an absolute value (ms since epoch) that's being passed?

[bokuweb]

@piscisaureus Thanks for your review. Sure. I confirmed that it was not passed.
For example when following code executed, timeout values are 3000, 2998.

setTimeout(() => console.log(1), 3000);
setTimeout(() => console.log(1), 6000);

[hayd]

When I tried before (I was the one who wrote the comment) I struggled to get js number to fbs int64 datatype working... The API was a little inconvenient, but is there.

IMO If we go with int32 then we should add a < maxint assert in ts (if we use int64 this wouldn't be needed iirc).

@bokuweb Did you try using int64 here?

[bokuweb]

@hayd OK :) Thanks for your comment. I did not try it. I think it is better.I'll fix it 👍

Ah... I see. Sorry, I did not understand... I tried it, but js number is not able to assign to long.
We have some options?

1. keep using float.
2. use int32 with assertion.
3. other??

However assertion is a bit exaggerated ?
In chrome, setTimeout(() => console.log(1), 2147483647 + 1) is executed immediately.
It is rounded??
Should we emulate that behavior??

[bokuweb]

In Node.js if timeout value is larger than int32, emit warning and fire callback in next tick.

https://github.com/nodejs/node/blob/master/lib/internal/timers.js#L57-L66

Should we imitate it?

[hayd]

Yes. Good investigating!

[bokuweb]

@piscisaureus @hayd Thanks for your comments. I fixed.

[ry]

Please make it so there's not a line break in the template literal.

[bokuweb]

@ry Thanks 👍fixed.

[bokuweb]

@ry @piscisaureus Is there anything I can do in this PR? :)

[piscisaureus]

@bokuweb Looked good to me so I landed it. Thanks!

[bokuweb]

@piscisaureus Thanks for your review :)