cleanup(ops): Remove dead code from codegen ops #14587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
force-pushed
the
cleanup/ops-less-dead-code
branch
from
cd7de8e
to
2a44cac
Compare
sigmaSd
pushed a commit
to sigmaSd/deno
that referenced
this pull request
May 29, 2022
…14587) Co-authored-by: Aaron O'Mullan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor further improvement on #14586: There's no need to wrap
resultintoOk(result)just to match againstResult.Additionally, there's no need to create
let ret = ()for return value-less ops.