feat(runtime/spawn): add AbortSignal support
#14538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
May 9, 2022
dsherret
reviewed
May 10, 2022
| this.#status = core.opAsync("op_spawn_wait", this.#rid).then((res) => { | ||
| this.#rid = null; | ||
| signal?.[remove](onAbort); |
There was a problem hiding this comment.
Should this be done in a .finally(...) so this gets unsubscribed if it ever throws? What about this.#rid = null?
There was a problem hiding this comment.
I dont think there is a scenario this would throw, and if it does, then i'd consider that a bug to some degree
dsherret
reviewed
May 10, 2022
Co-authored-by: David Sherret <[email protected]>
crowlKats
changed the title
signal support to abort subprocessAbortSignal support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #11579 for the new API