Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): add Deno.getGid #14528

Merged
merged 4 commits into from
May 31, 2022
Merged

feat(unstable): add Deno.getGid #14528

merged 4 commits into from
May 31, 2022

Conversation

imjamesb
Copy link
Contributor

@imjamesb imjamesb commented May 8, 2022

Adds Deno.getGid to unstable. The feature was never added in #13496

@imjamesb
feat(unstable): add Deno.getGid
cd60044 
Signed-off-by: James Bradlee <[email protected]>
@CLAassistant
Copy link

CLAassistant commented May 8, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@imjamesb
Copy link
Contributor Author

imjamesb commented May 8, 2022

off-topic, but I see I did a typo in the commit message.
op_getgit op_getgid

kt3k
kt3k approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit c41544a into denoland:main May 31, 2022
bartlomieju pushed a commit that referenced this pull request Jun 2, 2022
@imjamesb @bartlomieju
feat(unstable): add Deno.getGid (#14528)
3896f6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imjamesb @CLAassistant @kt3k