feat(test): Represent uncaught errors #14513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
May 7, 2022
Comment on lines
+812
to
+841
| fn report_uncaught_error(&mut self, origin: &str, js_error: &JsError) { | ||
| if self.current_origin == Some(origin.to_string()) { | ||
| self.current_origin = None; | ||
| } | ||
| let stack = self.stack.remove(origin).unwrap_or_default(); | ||
| let err_string = format!( | ||
| "Uncaught error from {}: {}\nThis error was not caught from a test and caused the test runner to fail on the referenced module.\nIt most likely originated from a dangling promise, event/timeout handler or top-level code.", | ||
| origin, | ||
| test::format_test_error(js_error) | ||
| ); | ||
| let messages = as_test_messages(err_string, false); | ||
| for t in stack.iter().rev() { | ||
| match t { | ||
| TestOrTestStepDescription::TestDescription(desc) => { | ||
| self.progress(lsp_custom::TestRunProgressMessage::Failed { | ||
| test: desc.into(), | ||
| messages: messages.clone(), | ||
| duration: None, | ||
| }); | ||
| } | ||
| TestOrTestStepDescription::TestStepDescription(desc) => { | ||
| self.progress(lsp_custom::TestRunProgressMessage::Failed { | ||
| test: desc.into(), | ||
| messages: messages.clone(), | ||
| duration: None, | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I did the lsp part by just making it fail any running test from that origin. cc @kitsonk
|
@nayeemrmn I tested this PR in VSCode, but I don't see a difference between this build and latest Deno, all I get is a prompt like this: |
I had forgotten to update the worker orchestration on the lsp side, it's done now. |
This reverts commit 4afa14b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14449.
cc @bartlomieju