Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.21.2 #14504

Merged
merged 3 commits into from
May 5, 2022
Merged

1.21.2 #14504

merged 3 commits into from
May 5, 2022

Conversation

denobot
Copy link
Collaborator

@denobot denobot commented May 5, 2022 •
edited by cjihrig
Loading

Bumped versions for 1.21.2

Please ensure:

  • Target branch is correct
  • Crate versions are bumped correctly
  • deno_std version is incremented in the code (see cli/compat/mod.rs)
  • Releases.md is updated correctly

To make edits to this PR:

git fetch upstream release_1_21.2 && git checkout -b release_1_21.2 upstream/release_1_21.2

cc @cjihrig

@cjihrig cjihrig marked this pull request as ready for review May 5, 2022 20:06
ry
ry approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but otherwise looks good!

Releases.md Outdated Show resolved Hide resolved
Releases.md Outdated Show resolved Hide resolved
@cjihrig
Revert "add missing commits"
e667287 
This reverts commit b4c0edc.

PR feedback - these are not relevant to users.
lucacasonato
lucacasonato approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bartlomieju
bartlomieju approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig cjihrig merged commit 2256c69 into v1.21 May 5, 2022
@cjihrig cjihrig deleted the release_1_21.2 branch May 5, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@AaronO AaronO Awaiting requested review from AaronO

@littledivy littledivy Awaiting requested review from littledivy littledivy is a code owner

@piscisaureus piscisaureus Awaiting requested review from piscisaureus piscisaureus is a code owner

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@denobot @ry @lucacasonato @bartlomieju @cjihrig