Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more fetch init body types #1449

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Support more fetch init body types #1449

merged 2 commits into from
Jan 3, 2019

Conversation

kevinkassimo
Copy link
Contributor

Add support to the following body init types:

  • Blob
  • URLSearchParams

Also make ./tools/http_server.py an echo server on POST /echo_server

kyranet
kyranet reviewed Jan 3, 2019
View reviewed changes
js/fetch.ts Outdated Show resolved Hide resolved
@kyranet @kevinkassimo
Update js/fetch.ts
c2544f3 
Co-Authored-By: kevinkassimo <[email protected]>
ry
ry approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/http_server.py
@@ -39,6 +39,24 @@ def do_GET(self):
return
return SimpleHTTPServer.SimpleHTTPRequestHandler.do_GET(self)

def do_POST(self):
# Simple echo server for request reflection
if "echo_server" in self.path:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ry ry merged commit 8d452d7 into denoland:master Jan 3, 2019
@kevinkassimo kevinkassimo deleted the fetch/init_body branch December 27, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinkassimo @ry @kyranet