Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/tools/test): Show Deno.test() call locations for failures #14484

Merged
merged 2 commits into from
May 4, 2022
Merged

feat(cli/tools/test): Show Deno.test() call locations for failures #14484

merged 2 commits into from
May 4, 2022

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented May 4, 2022 •
edited by bartlomieju
Loading

bartlomieju
bartlomieju reviewed May 4, 2022
View reviewed changes
cli/tests/testdata/test/exit_sanitizer.out Show resolved Hide resolved
cli/tools/test.rs Show resolved Hide resolved
cli/tools/test.rs Outdated Show resolved Hide resolved
runtime/js/40_testing.js Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Nayeem

@bartlomieju bartlomieju merged commit ca134d2 into denoland:main May 4, 2022
@nayeemrmn nayeemrmn deleted the failed-test-location branch May 5, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.test() call location in test failures test: Better headers for the three deno test sections
2 participants
@nayeemrmn @bartlomieju