Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add core.formatLocationFilename, remove op_format_filename #14474

Merged
merged 6 commits into from
May 3, 2022
Merged

refactor: add core.formatLocationFilename, remove op_format_filename #14474

merged 6 commits into from
May 3, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented May 3, 2022 •
edited
Loading

Closes #14464

This commit moves "op_format_location" to "core/ops_builtin.rs"
and removes "Deno.core.createPrepareStackTrace" in favor of
"Deno.core.prepareStackTrace".

@bartlomieju
Copy link
Member Author

@nayeemrmn please take a look

@bartlomieju bartlomieju requested a review from dsherret May 3, 2022 15:56
AaronO
AaronO reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving it into core makes sense, however it looks like this can remain an op (in ops_builtin.rs) and doesn't need to be promoted to a v8 binding

@bartlomieju bartlomieju requested a review from AaronO May 3, 2022 17:09
AaronO
AaronO reviewed May 3, 2022
View reviewed changes
core/error.rs Outdated Show resolved Hide resolved
@bartlomieju @AaronO
Update core/error.rs
b174f6a 
Co-authored-by: Aaron O'Mullan <[email protected]>
@bartlomieju bartlomieju requested a review from AaronO May 3, 2022 17:17
AaronO
AaronO reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 3f08a40 into denoland:main May 3, 2022
@bartlomieju bartlomieju deleted the op_format_file_name branch May 3, 2022 17:46
cjihrig pushed a commit that referenced this pull request May 5, 2022
@bartlomieju @AaronO @cjihrig
refactor: add core.formatLocationFilename, remove op_format_filename (#…
ffd4efe 
…14474)

This commit moves "op_format_location" to "core/ops_builtin.rs"
and removes "Deno.core.createPrepareStackTrace" in favor of
"Deno.core.prepareStackTrace".

Co-authored-by: Aaron O'Mullan <[email protected]>
cjihrig pushed a commit that referenced this pull request May 5, 2022
@bartlomieju @AaronO @cjihrig
refactor: add core.formatLocationFilename, remove op_format_filename (#…
81fd78a 
…14474)

This commit moves "op_format_location" to "core/ops_builtin.rs"
and removes "Deno.core.createPrepareStackTrace" in favor of
"Deno.core.prepareStackTrace".

Co-authored-by: Aaron O'Mullan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO approved these changes

@littledivy littledivy Awaiting requested review from littledivy

@kt3k kt3k Awaiting requested review from kt3k

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

op_format_file_name should probably be moved to deno_core
2 participants
@bartlomieju @AaronO