Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment(ops): sync Rc<RefCell<OpState>> #14438

Merged
merged 2 commits into from
May 5, 2022
Merged

experiment(ops): sync Rc<RefCell<OpState>> #14438

merged 2 commits into from
May 5, 2022

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 30, 2022

No description provided.

littledivy
littledivy approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two borrows happening now when arg is &mut OpState, we can reuse the borrow_mut after Self::call - not very important tho.

@AaronO AaronO self-assigned this Apr 30, 2022
@AaronO AaronO marked this pull request as ready for review May 1, 2022 03:20
@AaronO AaronO merged commit e04f1f1 into denoland:main May 5, 2022
@AaronO AaronO deleted the experiment/ops-sync-Rc-RefCell-OpState branch May 5, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy littledivy approved these changes

Assignees

@AaronO AaronO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AaronO @bartlomieju @littledivy