Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12558
Fixes: #14344
This adds the
lib.dom.extras.d.ts
file and modifies thelib.dom.d.ts
file to include it. This solves the problem where users use thelib: ["dom", "deno.ns"]
configuration when compiling their isomorphic TypeScript and the distributed version of the DOM library does not include every web standard API that Deno supports, and therefore causes confusing errors to the user.This means we do make a one line edit to the distributed
lib.dom.d.ts
to includelib.dom.extras.d.ts
. This means that users don't have to explicitly include"dom.extras"
when using the library, so for most users previous errors will just "go away".This does establish a pattern now where we can add items Deno supports in advance of the TypeScript distribution supporting it while allowing more isomorphic code to type check safely.