Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release fixes based on doing the v1.20.6 release #14289

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

dsherret
Copy link
Member

No description provided.

@@ -50,7 +50,7 @@ async function forwardReleaseCommitToMain() {
"checkout",
"-b",
newBranchName,
"main",
"origin/main",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe will fix...

Creating branch forward_v1.20.6...
Failed. Please manually open a PR. Error: Error executing git: fatal: 'main' is not a commit and a branch 'forward_v1.20.6' cannot be created from it

    at runCommand (https://raw.githubusercontent.com/denoland/automation/0.11.0/helpers.ts:24:11)
    at async forwardReleaseCommitToMain (file:https:///home/runner/work/deno/deno/tools/release/04_post_publish.ts:48:3)
    at async file:https:///home/runner/work/deno/deno/tools/release/04_post_publish.ts:15:3

# double the stack size to prevent swc overflowing the stack in debug
"link-arg=/STACK:2097152",
# increase the stack size to prevent swc overflowing the stack in debug
"link-arg=/STACK:1572864",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default stack size * 1.5

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit b4af648 into denoland:main Apr 15, 2022
@dsherret dsherret deleted the release_updates_v1_20_6 branch April 15, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants