chore: update release instructions based on 1.20.5 release #14239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
requested review from
bartlomieju,
kt3k and
piscisaureus
as code owners
dsherret
commented
Apr 8, 2022
| git config user.email "${{ github.actor }}@users.noreply.github.com" | ||
| git config user.name "${{ github.actor }}" | ||
| git config user.email "propelml@gmail.com" | ||
| git config user.name "denobot" |
There was a problem hiding this comment.
I thought it would be cuter if denobot bumps the versions.
dsherret
commented
Apr 8, 2022
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # the default secrets.GITHUB_TOKEN won't trigger a workflow run | ||
| # when tagging, but it will if we provide a custom PAT | ||
| GITHUB_TOKEN: ${{ secrets.DENOBOT_PAT }} |
There was a problem hiding this comment.
When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues I found along the way. Slowly getting there.