chore(ext/fetch): custom arity #14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
requested review from
AaronO,
bartlomieju,
crowlKats and
lucacasonato
as code owners
littledivy
changed the title
AaronO
reviewed
Apr 4, 2022
ry
reviewed
Apr 4, 2022
there is cargo-llvm-lines |
bartlomieju
approved these changes
Apr 22, 2022
Comment on lines
+188
to
194
| method: ByteString, | ||
| url: String, | ||
| headers: Vec<(ByteString, ByteString)>, | ||
| client_rid: Option<u32>, | ||
| has_body: bool, | ||
| body_length: Option<u64>, | ||
| data: Option<ZeroCopyBuf>, |
There was a problem hiding this comment.
That's a lot of arguments :P I'm not convinced this is preferable to having an "option bag", but if it results in fewer LLVM lines (and potentially faster compile) then we should go with it.
crowlKats
pushed a commit
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deno_fetchLLVM lines:
Before:
After: