Lazily create .mime files only with mismatch/no extension #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Dec 27, 2018
src/deno_dir.rs
Outdated
| @@ -28,6 +29,17 @@ pub struct CodeFetchOutput { | |||
| pub maybe_source_map: Option<Vec<u8>>, | |||
| } | |||
|
|
|||
| lazy_static! { | |||
| // Using str as key, since MediaType does not impl Eq and Hash | |||
| static ref EXTENSION_MAP: HashMap<&'static str, msg::MediaType> = { | |||
There was a problem hiding this comment.
Rather than using a static HashMap for this, I think it would be simpler to have a function: fn extmap(ext: &str) -> MediaType
src/deno_dir.rs
Outdated
| // Create .mime file only when content type different from extension | ||
| let resolved_content_type = map_content_type(&p, Some(&content_type)); | ||
| let dot_index = filename.rfind(".").unwrap_or(0); | ||
| let ext = filename.chars().skip(dot_index).collect::<String>(); |
There was a problem hiding this comment.
Is there not some dedicated std function for extracting the extension ?
There was a problem hiding this comment.
I haven't been able to find a proper one... I could have used byte slices but that is not quite safe in case of non-ascii characters...
There was a problem hiding this comment.
See if you can use this
https://doc.rust-lang.org/std/path/struct.Path.html#method.extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1333