Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 #14165

Merged
merged 3 commits into from
Mar 31, 2022
Merged

1.20.4 #14165

merged 3 commits into from
Mar 31, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 31, 2022

Bumped versions for 1.20.4

Please ensure:

  • Crate versions are bumped correctly
  • deno_std version is incremented in the code
  • Releases.md is updated correctly

To make edits to this PR:

git fetch upstream release_1_20.4 && git checkout -b release_1_20.4 upstream/release_1_20.4

cc @dsherret

@dsherret
Copy link
Member

dsherret commented Mar 31, 2022

Updating Releases.md failed, but other than that looks good:

Error: Error executing git: fatal: No tags can describe 'd5cd7c3261427fac3cf2b1aef8f38640596e9859'.
Try --always, or create some tags.

    at runCommand (https://raw.githubusercontent.com/denoland/automation/0.9.0/helpers.ts:24:11)
    at async Repo.gitLatestTag (https://raw.githubusercontent.com/denoland/automation/0.9.0/repo.ts:283:13)
    at async getGitLog (file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:87:21)
    at async getReleasesMdText (file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:62:18)
    at async updateReleasesMd (file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:48:22)
    at async file:https:///home/runner/work/deno/deno/tools/release/01_bump_crate_versions.ts:35:3
Updating Releases.md failed. Please manually run `git log --oneline VERSION_FROM..VERSION_TO` and use the output to update Releases.md

Edit: Cool. I can reproduce this if I follow what the CI does in a fresh directory.
Edit 2: Opened #14166 for next time.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@dsherret dsherret merged commit a78f728 into v1.20 Mar 31, 2022
@dsherret dsherret deleted the release_1_20.4 branch March 31, 2022 17:09
dsherret added a commit to dsherret/deno that referenced this pull request Mar 31, 2022
Co-authored-by: David Sherret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants