cleanup(serde_v8): simpler ZeroCopyBuf #14095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Mar 24, 2022
littledivy
reviewed
Mar 24, 2022
Comment on lines
+55
to
+60
| unsafe { &*(&self.store[self.range.clone()] as *const _ as *const [u8]) } | ||
| } | ||
|
|
||
| #[allow(clippy::cast_ref_to_mut)] | ||
| fn as_slice_mut(&mut self) -> &mut [u8] { | ||
| unsafe { &mut *(&self.store[self.range.clone()] as *const _ as *mut [u8]) } |
There was a problem hiding this comment.
The soundness of these methods relies on the BackingStore not being deref'd during the lifetime of the returned slices. This can happen if a SharedRef<BackingStore> is stored somewhere before deserializing the ArrayBuffer, or if a single buffer is deserialized multiple times.
bartlomieju
approved these changes
Mar 24, 2022
dsherret
pushed a commit
that referenced
this pull request
Apr 7, 2022
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.