feat(core): disableable extensions & ops #14063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamlines a common middleware pattern and provides foundations for avoiding variably sized v8::ExternalReferences & enabling fully monomorphic op callpaths
Op middleware has the final say on whether an op is enabled/disabled/overridden, otherwise the logic is:
Entire extensions can be enabled/disabled, individual ops can also toggled in the extension constructor.
Main semi-open question is if disabled ops should throw or just no-op by mapping to
op_void_a?sync
thus returningundefined
(no-op-ing is our current behaviour so I'm going to stick with that)