perf(http): avoid per header alloc #14051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
requested review from
bartlomieju,
crowlKats,
lucacasonato and
littledivy
as code owners
bartlomieju
reviewed
Mar 21, 2022
Yes, there's a 1-3% improvement, I've discussed with @littledivy a bench that would bypass the OS' net stack & loadgen tool better suited to measuring http-efficiency & should have less variance. |
lucacasonato
approved these changes
Mar 21, 2022
kitsonk
pushed a commit
to kitsonk/deno
that referenced
this pull request
Mar 23, 2022
kitsonk
pushed a commit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if header matches a "special" header (that impacts our body handling, etc...)
make_ascii_lowercase could also make sense here
Impact on throughput
Unfortunately there's a lot of variance in our tests and it's not fully formalized but I do observe a 1-3% improvement in throughput (sampled over 3 runs):