chore: fix development issues on Windows #14030
Conversation
dsherret
requested review from
bartlomieju,
kt3k and
piscisaureus
as code owners
| @@ -2334,7 +2334,7 @@ fn issue9750() { | |||
| Input("yy\n"), | |||
| Output("⚠️ ️Deno requests env access. Run again with --allow-env to bypass this prompt.\r\n Allow? [y/n (y = yes allow, n = no deny)]"), | |||
| Input("n\n"), | |||
| Output("⚠️ ️Deno requests env access to \"SECRET\". Run again with --allow-run to bypass this prompt.\r\n Allow? [y/n (y = yes allow, n = no deny)]"), | |||
| Output("⚠️ ️Deno requests env access to \"SECRET\". Run again with --allow-env to bypass this prompt.\r\n Allow? [y/n (y = yes allow, n = no deny)]"), | |||
There was a problem hiding this comment.
Ummm... how is this passing on linux & mac? (these tests don't run on the CI on Windows)
There was a problem hiding this comment.
This fails for me on linux and then hangs forever. I think these tests also are not running the CI on Linux & Mac because it's not a tty. I guess nobody ever runs the full test suite locally that often (been broken for over a month). I only did because I'm trying to upgrade swc.
There was a problem hiding this comment.
See #14014, couldn't figure out why CI wasn't failing but was hanging locally, seems you figured it out.
| # double the stack size to prevent swc overflowing the stack in debug | ||
| "link-arg=/STACK:2097152", |
There was a problem hiding this comment.
That happened in the past? FWIW swc’s tests on its repo requires increasing the stack size.
There was a problem hiding this comment.
Yeah, I believe we once increased stack size on Windows, but then there were some improvements that rendered it unneeded
There was a problem hiding this comment.
I think probably something must have increased on our side that just tipped it over. It never used to stack overflow on Windows with this swc version.
Fixes some local development issues that have creeped up over the past few weeks on Windows.
Please merge on review
Closes #14014