Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Rust toolchain components #14004

Merged
merged 2 commits into from
Mar 17, 2022
Merged

chore: add Rust toolchain components #14004

merged 2 commits into from
Mar 17, 2022

Conversation

littledivy
Copy link
Member

dsherret
dsherret approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we could remove the component adds from the ci.yml file now though?

kt3k
kt3k approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 3c47500 into denoland:main Mar 17, 2022
@littledivy littledivy deleted the toolchain_items branch March 17, 2022 16:24
kitsonk pushed a commit to kitsonk/deno that referenced this pull request Mar 23, 2022
@littledivy @kitsonk
chore: add Rust toolchain components (denoland#14004)
97a32bd
kitsonk pushed a commit that referenced this pull request Mar 24, 2022
@littledivy @kitsonk
chore: add Rust toolchain components (#14004)
06d6fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @kt3k @dsherret