Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build #13997

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix build #13997

merged 2 commits into from
Mar 17, 2022

Conversation

ry
Copy link
Member

@ry ry commented Mar 17, 2022

  • fix node_resolver
  • fix warning

dsherret
dsherret approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/tools/lint.rs
@@ -550,7 +550,7 @@ pub(crate) fn get_configured_rules(
);

if configured_rules.is_empty() {
anyhow!("No rules have been configured");
return Err(anyhow!("No rules have been configured"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this wasn't a clippy failure or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a warning locally, but it seems we're not failing on warnings for some reason. I thought this should be doing it:

deno/.github/workflows/ci.yml

Lines 150 to 153 in 92bb251

- name: Error on warning
# TODO(piscisaureus): enable this on Windows again.
if: "!startsWith(matrix.os, 'windows')"
run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe it should be echo "RUSTFLAGS='-D warnings'" >> $GITHUB_ENV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #13998

@ry ry merged commit 18f998f into denoland:main Mar 17, 2022
@ry ry deleted the fix-release branch March 17, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @dsherret