Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): restore compatibility with old glibc #13846

Merged
merged 11 commits into from
Mar 8, 2022
Merged

fix(ci): restore compatibility with old glibc #13846

merged 11 commits into from
Mar 8, 2022

Conversation

piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented Mar 6, 2022 •
edited
Loading

Fixes: #13516

@piscisaureus piscisaureus marked this pull request as draft March 6, 2022 06:24
littledivy
littledivy approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on AMI Linux 2

LGTM (once cleaned up and the tests pass)

@piscisaureus piscisaureus marked this pull request as ready for review March 7, 2022 23:19
bartlomieju
bartlomieju approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju mentioned this pull request Mar 8, 2022
Closed
@piscisaureus piscisaureus merged commit 566a149 into denoland:main Mar 8, 2022
@piscisaureus piscisaureus deleted the glibc branch March 8, 2022 02:07
kt3k pushed a commit that referenced this pull request Mar 10, 2022
@piscisaureus @kt3k
fix(ci): restore compatibility with older glibc (#13846)
2c4ab1b 
Fixes: #13516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy littledivy approved these changes

@kt3k kt3k Awaiting requested review from kt3k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno upgrade to 1.18.1 fails on Ubuntu 16.04 with "GLIBC_2.27 not found"
3 participants
@piscisaureus @bartlomieju @littledivy