fix(compat): cjs/esm interop for dynamic imports

[bartlomieju]

This commit fixes CJS/ESM interop in compat mode for dynamically
imported modules.

"ProcState::prepare_module_load" was changed to accept a list
of "graph roots" without associated "module kind". That module kind
was always hardcoded to "ESM" which is not true for CJS/ESM interop -
a CommonJs module might be imported using "import()" function. In
such case the root of the graph should have "CommonJs" module kind
instead of "ESM".

Fixes #13790

[bartlomieju]

Culprit is here:

deno/cli/module_loader.rs

Lines 109 to 120 in a41d399

	async move {
	ps.prepare_module_load(
	vec![(specifier, deno_graph::ModuleKind::Esm)],
	is_dynamic,
	lib,
	root_permissions,
	dynamic_permissions,
	false,
	)
	.await
	}
	.boxed_local()

Root of the graph is always marked as ESM, which in this instance is not correct.

[bartlomieju]

@kitsonk could you take a look? I feel we should be using resolver inside ModuleLoader::prepare_load and pass resolved specifier and module kind based on the ResolveResponse instead of hard coding module kind to Esm.

[bartlomieju]

ping @kitsonk

[kitsonk]

Ah sorry, missed this. I will look tomorrow my time, apologies!

[kitsonk]

LGTM

[kitsonk]

Ref: denoland/deno_graph#140

[bartlomieju]

Thanks for opening this!