Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dead code from lsp #13743

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 23, 2022

In #12968 #[allow(unused)] was added, but never removed. Since then there is a significant amount of dead code and other things that have creeped into the whole of the lsp. This PR cleans all that up.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitsonk kitsonk merged commit 973fe6d into denoland:main Feb 23, 2022
@kitsonk kitsonk deleted the refactor_lsp_dead_code branch February 23, 2022 21:01
dsherret pushed a commit to dsherret/deno that referenced this pull request Feb 24, 2022
dsherret pushed a commit that referenced this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants