feat: allow specification of import map in config file #13739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Feb 22, 2022
kitsonk
force-pushed
the
kitsonk/issue12800
branch
from
bf81b76
to
1cac049
Compare
dsherret
approved these changes
Feb 22, 2022
| if let Some(import_map_path) = maybe_import_map_path { | ||
| if let Some(config_file) = &maybe_config_file { | ||
| if config_file.to_import_map_path().is_some() { | ||
| log::warn!("{} the configuration file \"{}\" contains an entry for \"importMap\" that is being ignored.", crate::colors::yellow("Warning"), config_file.specifier); |
There was a problem hiding this comment.
If someone explicitly provides an import map as a cli flag I'm not sure we need to warn them about it because it should hopefully be obvious. Maybe we should warn though... not sure.
There was a problem hiding this comment.
I think it's fine, users can always specify --quiet to silence these warnings
There was a problem hiding this comment.
Because we have auto detection now, I think it is important, as you can be there scratching your head why your code isn't working. As noted --quiet can suppress it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12800