Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): provide completions from import map if available #13624

Merged
merged 3 commits into from
Feb 9, 2022
Merged

feat(lsp): provide completions from import map if available #13624

merged 3 commits into from
Feb 9, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 8, 2022

Closes #13619

(This also updates to import_map v0.8.0)

@kitsonk kitsonk requested a review from dsherret February 8, 2022 04:33
dsherret
dsherret approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 773f882 into denoland:main Feb 9, 2022
@kitsonk kitsonk deleted the kitsonk/issue13619 branch February 9, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: import completions include import maps
2 participants
@kitsonk @dsherret