Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): update to TypeScript 4.6.2 #13474

Merged
merged 5 commits into from
Mar 1, 2022
Merged

feat(cli): update to TypeScript 4.6.2 #13474

merged 5 commits into from
Mar 1, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jan 24, 2022

No description provided.

@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 24, 2022

Note that the official typings for Error.prototype.cause are being set to Error, which also reflects what is indicated in mdn, and I assume it was taken from the WebIDL. We had patched it slightly differently when we added the types, but I recommend we move over to the stricter types and fix any regressions it causes.

@crowlKats
Copy link
Member

crowlKats commented Jan 24, 2022

Hm quite annoying about cause, as the spec doesnt specify whatsoever what it should be, and imo it make sense that it can be anything. Not sure why TS decided it has to be an Error. From looking at PR and issue in the TS repo, there was no discussion in that regard wahtsoever

@kitsonk
Copy link
Contributor Author

kitsonk commented Jan 24, 2022

Well and some of the examples they use aren't strict mode compatible, cause catch(err) is unknown in strict mode now... It maybe worth raising a PR/issue to get it changed, as it in theory should be unknown to match the strict behaviour of catch(err).

@kitsonk kitsonk changed the title [WIP] feat(cli): TypeScript 4.6-beta feat(cli): update to TypeScript 4.6.2 Mar 1, 2022
@kitsonk kitsonk marked this pull request as ready for review March 1, 2022 10:37
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As a side note, do we have instructions how to do update to newer TypeScript version in case you weren't able to do it?

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 1, 2022

I'll add something

@kitsonk kitsonk merged commit 7fc5bfe into denoland:main Mar 1, 2022
@kitsonk kitsonk deleted the ts_46 branch March 1, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants