perf(lsp): improve some tsc op hot paths #13473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jan 24, 2022
dsherret
reviewed
Jan 24, 2022
| @@ -949,6 +949,22 @@ impl Documents { | |||
| } | |||
| } | |||
|
|
|||
| /// Used by the tsc op_exists to shortcut trying to load a document to provide | |||
| /// information to CLI without allocating a document. | |||
| pub(crate) fn exists(&self, specifier: &ModuleSpecifier) -> bool { | |||
There was a problem hiding this comment.
It's a little strange that we now have exists and contains_specifier, which both do the same thing. I don't think we need two methods. What's the performance impact of using contains_specifier vs exist? When TypeScript does an exists call it will then do a second call load the file, so is it a big deal to just load it when doing .contains_specifier() as it will just be loaded right after?
bartlomieju
pushed a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chasing down another issues I realised that while individual
op_existsandop_script_versionare not performance issues themselves, they are often called 1000s of time per document and we should really try to be as efficient with them as possible.