chore: upgrade to rust 1.58.1 #13459
Conversation
littledivy
requested review from
bartlomieju,
kt3k and
piscisaureus
as code owners
rust-toolchain
Outdated
| @@ -0,0 +1 @@ | |||
| 1.58.1 | |||
There was a problem hiding this comment.
It will cause cargo to always build on 1.58.1
| @@ -0,0 +1,2 @@ | |||
| [toolchain] | |||
| channel = "1.58.1" | |||
There was a problem hiding this comment.
Is this necessary? all these random root level files are fairly annoying.
There was a problem hiding this comment.
It's just to make sure local builds (like Apple M1) happen from the same toolchain.
There was a problem hiding this comment.
It will prevent time spent on these scenarios: https://discord.com/channels/684898665143206084/684911491035430919/931238729841016902
And as @littledivy mentioned in discord, it will also ensure anyone doing an M1 build builds with the correct rust version. I think it's worth it, but do agree it's a little annoying to have yet another file in the root.
There was a problem hiding this comment.
It's just to make sure local builds (like Apple M1) happen from the same toolchain.
Is there an alternative?
There was a problem hiding this comment.
Yes but none are persistent: https://rust-lang.github.io/rustup/overrides.html#overrides
Note that we also have this in rusty_v8 https://github.com/denoland/rusty_v8/blob/main/rust-toolchain
There was a problem hiding this comment.
It's a shame it seems like rust-toolchain.toml is not respected in the .cargo directory.
There was a problem hiding this comment.
Also, it's nice to have a single source of truth for our rust version after this PR (if we have this file)
Due to Race condition in std::fs::remove_dir_all
Also adds a
rust-toolchain